netdev - Re: [PATCHv2] net: smsc911x: don't artificially limit build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130509102650.GC8258@e106331-lin.cambridge.arm.com>
Date:	Thu, 9 May 2013 11:26:50 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"David S. Miller" <davem@...emloft.net>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCHv2] net: smsc911x: don't artificially limit build

This should of course be PATCH, not PATCHv2.

I blame my shell's command history completion.

Mark.

On Thu, May 09, 2013 at 11:23:47AM +0100, Mark Rutland wrote:
> Currently the SMSC911X driver may only be built for a specific set of
> architectures, being limited to do so by a Kconfig depends line. This
> means that if a platform wishes to use the driver, its architecture must
> be added to the list explicitly, introducing pointless churn.
> 
> This may have been due to the driver's use of the {read,write}s{b,w,l}
> functions, which have since been replaced with the more standard
> io{read,write}{8,16,32}_rep. We can instead depend on HAS_IOMEM, which
> should prevent build issues while allowing the driver to be built for
> currently unlisted architectures, including x86 and arm64.
> 
> This patch removes the explicit list of architectures from the driver's
> depend line, and replaces it with a dependency on HAS_IOMEM.
> 
> Signed-off-by: Mark Rutland <mark.rutland@....com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/ethernet/smsc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/smsc/Kconfig
> index bb4c167..ff9e994 100644
> --- a/drivers/net/ethernet/smsc/Kconfig
> +++ b/drivers/net/ethernet/smsc/Kconfig
> @@ -97,7 +97,7 @@ config SMC911X
>  
>  config SMSC911X
>  	tristate "SMSC LAN911x/LAN921x families embedded ethernet support"
> -	depends on (ARM || SUPERH || BLACKFIN || MIPS || MN10300)
> +	depends on HAS_IOMEM
>  	select CRC32
>  	select NET_CORE
>  	select MII
> -- 
> 1.8.1.1
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html