netdev - Re: is L1 really disabled in iwlwifi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1368303730.2425.47.camel@x230>
Date:	Sat, 11 May 2013 20:22:11 +0000
From:	Matthew Garrett <matthew.garrett@...ula.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
CC:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Emmanuel Grumbach <egrumbach@...il.com>,
	Stanislaw Gruszka <sgruszka@...hat.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	John Linville <linville@...driver.com>,
	Roman Yepishev <roman.yepishev@...il.com>,
	"Guy, Wey-Yi" <wey-yi.w.guy@...el.com>,
	Mike Miller <mike.miller@...com>,
	"iss_storagedev@...com" <iss_storagedev@...com>,
	Guo-Fu Tseng <cooldavid@...ldavid.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Francois Romieu <romieu@...zoreil.com>,
	"nic_swsd@...ltek.com" <nic_swsd@...ltek.com>,
	"aacraid@...ptec.com" <aacraid@...ptec.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: is L1 really disabled in iwlwifi

On Sat, 2013-05-11 at 22:26 +0200, Rafael J. Wysocki wrote:
> On Friday, May 10, 2013 04:52:57 PM Bjorn Helgaas wrote:
> > I propose the following patch.  Any comments?
> 
> In my opinion this is dangerous, because it opens us to bugs that right now
> are prevented from happening due to the way the code works.

Right, I'm also not entirely comfortable with this. The current
behaviour may be confusing, but we could reduce that by renaming the
functions. I'm still not clear on whether anyone's actually seeing
problems caused by the existing behaviour.

-- 
Matthew Garrett | mjg59@...f.ucam.org