netdev - NETDEV_FEAT_CHANGE and ethtool (question)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 May 2013 12:21:45 +0300
From:	Andy Johnson <johnsonzjo@...il.com>
To:	netdev@...r.kernel.org
Subject: NETDEV_FEAT_CHANGE and ethtool (question)

Hello,

The only thing that netdev_features_change() does is send
NETDEV_FEAT_CHANGE event
notification.

NETDEV_FEAT_CHANGE event is sent in the core from
netdev_update_features() if __netdev_update_features returned 1, and
this event is *always* sent from netdev_change_features().

ethtool calls __netdev_update_features() when chaning features. So
changing GSO offload features for example, by
"ethtool -K gso off" will *not* trigger NETDEV_FEAT_CHANGE event notification.
(assuming that ndo_fix_features/ndo_set_features callbacks of the
driver, if exist, will not
trigger such noticiation call).

My question is: why changing features by ethtool does not trigger
sending NETDEV_FEAT_CHANGE event?

Best,
Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html