netdev - Re: NETDEV_FEAT_CHANGE and ethtool (question)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF0Lin2V3QyKCDfZkY_zB8StK+GUR+Qwtb64LQ3maJgVJBT7fw@mail.gmail.com>
Date:	Sun, 12 May 2013 23:49:42 +0300
From:	Andy Johnson <johnsonzjo@...il.com>
To:	Michał Mirosław <mirqus@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: NETDEV_FEAT_CHANGE and ethtool (question)

Hello,
Thanks!

You are right.

sorry for missing this:
int dev_ethtool()
{
...
if (old_features != dev->features)
netdev_features_change(dev);
}

Best,
Andy

On Sun, May 12, 2013 at 10:18 PM, Michał Mirosław <mirqus@...il.com> wrote:
> 2013/5/12 Andy Johnson <johnsonzjo@...il.com>:
>> Hello,
>>
>> The only thing that netdev_features_change() does is send
>> NETDEV_FEAT_CHANGE event
>> notification.
>>
>> NETDEV_FEAT_CHANGE event is sent in the core from
>> netdev_update_features() if __netdev_update_features returned 1, and
>> this event is *always* sent from netdev_change_features().
>>
>> ethtool calls __netdev_update_features() when chaning features. So
>> changing GSO offload features for example, by
>> "ethtool -K gso off" will *not* trigger NETDEV_FEAT_CHANGE event notification.
>> (assuming that ndo_fix_features/ndo_set_features callbacks of the
>> driver, if exist, will not
>> trigger such noticiation call).
>>
>> My question is: why changing features by ethtool does not trigger
>> sending NETDEV_FEAT_CHANGE event?
>
> You didn't verify this assumption. See dev_ethtool()'s last check.
>
> Best Regards,
> Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html