netdev - RE: [PATCH -next] qlcnic: convert list_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 May 2013 15:57:12 +0000
From:	Shahed Shaikh <shahed.shaikh@...gic.com>
To:	Wei Yongjun <weiyj.lk@...il.com>,
	Rajesh Borundia <rajesh.borundia@...gic.com>,
	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>,
	Sony Chacko <sony.chacko@...gic.com>
CC:	"yongjun_wei@...ndmicro.com.cn" <yongjun_wei@...ndmicro.com.cn>,
	Dept-Eng Linux Driver <Linux-Driver@...gic.com>,
	netdev <netdev@...r.kernel.org>
Subject: RE: [PATCH -next] qlcnic: convert list_for_each to entry variant


> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@...il.com]
> Sent: Monday, May 13, 2013 2:31 PM
> To: Rajesh Borundia; Shahed Shaikh; Jitendra Kalsaria; Sony Chacko
> Cc: yongjun_wei@...ndmicro.com.cn; Dept-Eng Linux Driver; netdev
> Subject: [PATCH -next] qlcnic: convert list_for_each to entry variant
> 
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> convert list_for_each() to list_for_each_entry().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> index 8fb836d..d7d4851 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> @@ -311,10 +311,8 @@ int qlcnic_read_mac_addr(struct qlcnic_adapter
> *adapter)  static void qlcnic_delete_adapter_mac(struct qlcnic_adapter
> *adapter)  {
>  	struct qlcnic_mac_list_s *cur;
> -	struct list_head *head;
> 
> -	list_for_each(head, &adapter->mac_list) {
> -		cur = list_entry(head, struct qlcnic_mac_list_s, list);
> +	list_for_each_entry(cur, &adapter->mac_list, list) {
>  		if (!memcmp(adapter->mac_addr, cur->mac_addr,
> ETH_ALEN)) {
>  			qlcnic_sre_macaddr_change(adapter, cur-
> >mac_addr,
>  						  0, QLCNIC_MAC_DEL);
> 

Thanks!

Acked-by: Shahed Shaikh <shahed.shaikh@...gic.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html