netdev - Re: [PATCH] qlge: fix dma map leak when the last chunk is not allocated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130513.125510.225110585775124505.davem@davemloft.net>
Date:	Mon, 13 May 2013 12:55:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cascardo@...ux.vnet.ibm.com
Cc:	netdev@...r.kernel.org, linux-driver@...gic.com,
	shahed.shaikh@...gic.com, jitendra.kalsaria@...gic.com,
	ron.mercer@...gic.com
Subject: Re: [PATCH] qlge: fix dma map leak when the last chunk is not
 allocated

From: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
Date: Sat, 11 May 2013 16:15:37 -0300

> qlge allocates chunks from a page that it maps and unmaps that page when
> the last chunk is released. When the driver is unloaded or the card is
> removed, all chunks are released and the page is unmapped for the last
> chunk.
> 
> However, when the last chunk of a page is not allocated and the device
> is removed, that page is not unmapped. In fact, its last reference is
> not put and there's also a page leak. This bug prevents a device from
> being properly hotplugged.
> 
> When the DMA API debug option is enabled, the following messages show
> the pending DMA allocation after we remove the driver.
> 
> This patch fixes the bug by unmapping and putting the page from the ring
> if its last chunk has not been allocated.
....
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html