netdev - Re: [PATCH v2 net 2/2] tg3: Fix data corruption on 5725 with TSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1368479644.13473.121.camel@edumazet-glaptop>
Date:	Mon, 13 May 2013 14:14:04 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Nithin Nayak Sujir <nsujir@...adcom.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Michael Chan <mchan@...adcom.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2 net 2/2] tg3: Fix data corruption on 5725 with TSO

On Mon, 2013-05-13 at 14:04 -0700, Nithin Nayak Sujir wrote:
> From: Michael Chan <mchan@...adcom.com>
> 
> The 5725 family of devices (asic rev 5762), corrupts TSO packets where
> the buffer is within MSS bytes of a 4G boundary (4G, 8G etc.). Detect
> this condition and trigger the workaround path.
> 
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Michael Chan <mchan@...adcom.com>
> Signed-off-by: Nithin Nayak Sujir <nsujir@...adcom.com>
> ---
>  drivers/net/ethernet/broadcom/tg3.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index 781be76..e285d76 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -7448,6 +7448,20 @@ static inline int tg3_4g_overflow_test(dma_addr_t mapping, int len)
>  	return (base > 0xffffdcc0) && (base + len + 8 < base);
>  }
>  
> +/* Test for TSO DMA buffers that cross into regions which are within MSS bytes
> + * of any 4GB boundaries: 4G, 8G, etc
> + */
> +static inline int tg3_4g_tso_overflow_test(struct tg3 *tp, dma_addr_t mapping,
> +					   u32 len, u32 mss)
> +{
> +	if (tg3_asic_rev(tp) == ASIC_REV_5762 && mss) {
> +		u32 base = (u32) mapping & 0xffffffff;
> +
> +		return ((base + len + (mss & 0x3fff)) < base);
> +	}
> +	return 0;
> +}
> +

I am curious : Does this condition even triggers ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html