lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 May 2013 10:38:44 +0100 From: "David Laight" <David.Laight@...LAB.COM> To: "Nicolas Ferre" <nicolas.ferre@...el.com>, "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org> Cc: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, "Jean-Christophe PLAGNIOL-VILLARD" <plagnioj@...osoft.com>, <hein_tibosch@...oo.es>, <s.trumtrar@...gutronix.de>, <michal.simek@...inx.com>, <monstr@...str.eu>, "Havard Skinnemoen" <havard@...nnemoen.net> Subject: RE: [PATCH 3/3 v3] net/macb: Try to optimize struct macb layout > Move TX-related fields to the top of the struct so that they end up on > the same cache line. Move the NAPI struct below that since it is used > from the interrupt handler. This field is also marked as > ___cacheline_aligned_in_smp. > RX-related fields go below those. > Function pointers and capability mask are immediately after that as > they are also used in the hot path. > > Move the spinlock before regs since they are usually used together. Haven't you introduced some holes in the structure? I suspect that spinloack_t might only be 32bits on some 64bit systems. There is certainly one where 'caps' used to be. ...> > struct macb { > + spinlock_t lock; > void __iomem *regs; ... > + struct macb_or_gem_ops macbgem_ops; > + > + u32 caps; > > - spinlock_t lock; > struct platform_device *pdev; David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists