netdev - Re: [Patch iproute2] vxlan: use 8472 as default dst port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OFA8084FAB.8443890D-ON85257B6C.003F1FAB-85257B6C.003F65F2@us.ibm.com>
Date:	Wed, 15 May 2013 07:32:28 -0400
From:	David Stevens <dlstevens@...ibm.com>
To:	Cong Wang <amwang@...hat.com>
Cc:	Cong Wang <amwang@...hat.com>, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [Patch iproute2] vxlan: use 8472 as default dst port

netdev-owner@...r.kernel.org wrote on 05/15/2013 07:11:10 AM:

> From: Cong Wang <amwang@...hat.com>

> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Signed-off-by: Cong Wang <amwang@...hat.com>
> 
> ---
> diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
> index 2d93ee2..a0c90b3 100644
> --- a/ip/iplink_vxlan.c
> +++ b/ip/iplink_vxlan.c
> @@ -53,7 +53,7 @@ static int vxlan_parse_opt(struct link_util *lu, 
> int argc, char **argv,
>     __u8 noage = 0;
>     __u32 age = 0;
>     __u32 maxaddr = 0;
> -   __u16 dstport = 4789;
> +   __u16 dstport = 8472;

I think this should be "0"; then it will use the kernel port,
whatever it is.

> @@ -188,8 +188,7 @@ static int vxlan_parse_opt(struct link_util *lu,
> int argc, char **argv,
>     if (range.low || range.high)
>        addattr_l(n, 1024, IFLA_VXLAN_PORT_RANGE,
>             &range, sizeof(range));
> -   if (dstport)
> -      addattr16(n, 1024, IFLA_VXLAN_PORT, htons(dstport));
> +   addattr16(n, 1024, IFLA_VXLAN_PORT, htons(dstport));

        ...and these lines should be left alone. If not specified,
it won't pass an alternate port and will use the kernel default.

                                                +-DLS


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html