netdev - Re: [patch] ipg: fix an unsigned widening cast of '~' truncation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 15 May 2013 14:54:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	romieu@...zoreil.com, sorbica@...lus.com.tw,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] ipg: fix an unsigned widening cast of '~' truncation
 issue

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 15 May 2013 10:20:02 +0300

> The bug here is this code from ipg_nic_hard_start_xmit():
> 
> 	txfd->tfc &= cpu_to_le64(~IPG_TFC_TFDDONE);
> 
> IPG_TFC_TFDDONE is 0x0000000080000000 so it's an unsigned int.  The
> negated value is 0x7fffffff but 0xffffffff7fffffff was intended.
> 
> The other values in this file don't need to be changed but I did it for
> consistency.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html