netdev - Re: [PATCH 2/2] fec: Invert the order of function calls in fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130515.145449.143324877111226754.davem@davemloft.net>
Date:	Wed, 15 May 2013 14:54:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fabio.estevam@...escale.com
Cc:	shawn.guo@...aro.org, Frank.Li@...escale.com,
	kernel@...gutronix.de, eric.dumazet@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] fec: Invert the order of function calls in
 fec_restart()

From: Fabio Estevam <fabio.estevam@...escale.com>
Date: Wed, 15 May 2013 14:06:27 -0300

> commit 54309fa6 ("net: fec: fix kernel oops when plug/unplug cable many times")
> introduced the following 'if' block in the beginning of fec_start():
 ...
> Then later in the end of fec_restart() there is another block that calls the
> opposite of each one of these functions.
> 
> The correct approach would be to also call them with in the reverse order, so 
> that we have as result:
 ...
> Suggested-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html