netdev - Re: [PATCH] bonding: allow TSO being set on bonding master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 May 2013 00:55:40 +0200
From:	Michał Mirosław <mirqus@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, Jay Vosburgh <fubar@...ibm.com>,
	Maciej Żenczykowski <maze@...gle.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Tom Herbert <therbert@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH] bonding: allow TSO being set on bonding master

2013/5/15 Eric Dumazet <eric.dumazet@...il.com>:
> From: Eric Dumazet <edumazet@...gle.com>
>
> In some situations, we need to disable TSO on bonding slaves.
>
> bonding device automatically unset TSO in bond_fix_features(), and
> performance is not good because :
>
> 1) We consume more cpu cycles.
>
> 2) GSO segmentation has some bugs leading to out of order TCP packets
> if this segmentation is done before virtual device. This particular
> problem will be addressed in a separate patch.
>
> This patch allows TSO being set/unset on the bonding master,
> so that GSO segmentation is done after bonding layer.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Jay Vosburgh <fubar@...ibm.com>
> Cc: Andy Gospodarek <andy@...yhouse.net>
> Cc: Maciej Żenczykowski <maze@...gle.com>
> Cc: Tom Herbert <therbert@...gle.com>
> Cc: Neal Cardwell <ncardwell@...gle.com>
> Cc: Yuchung Cheng <ycheng@...gle.com>
> ---
>  drivers/net/bonding/bond_main.c |    5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index d0aade0..b429bb8 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1362,6 +1362,11 @@ static netdev_features_t bond_fix_features(struct net_device *dev,
>                                                      slave->dev->features,
>                                                      mask);
>         }
> +       /* Allow TSO being used on bonding device :
> +        * Performing the GSO segmentation after bonding transmit
> +        * is a performance improvement.
> +        */
> +       features |= mask & NETIF_F_ALL_TSO;
>
>  out:
>         read_unlock(&bond->lock);

Have you tried adding it to NETIF_F_ONE_FOR_ALL set? 'Team' and bridge
could then also use it.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html