netdev - Re: [PATCH] tcp: gso: do not generate out of order packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1368679608.4519.105.camel@edumazet-glaptop>
Date:	Wed, 15 May 2013 21:46:48 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Maciej Żenczykowski <zenczykowski@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Tom Herbert <therbert@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH] tcp: gso: do not generate out of order packets

On Wed, 2013-05-15 at 20:58 -0700, Maciej Żenczykowski wrote:

> Could we instead move the queue mapping into the skb somehow instead?

Quite frankly all the ndo_select_queue() / ARFS / XPS stuff are already
a mess.

You need a socket pointer to be able to change the queue numbers we
cache in it. We lack this information at GSO segmentation.

Let's do GSO properly and provide skbs exactly like if they were built
by TCP stack. (Well, there _is_ some difference, as the truesize will
have less overhead)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html