netdev - [RFC] assign some address families for local use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1483365.AWhs4mCphi@harkonnen>
Date:	Thu, 16 May 2013 17:49:46 +0200
From:	Federico Vaga <federico.vaga@...il.com>
To:	"David S. Miller" <davem@...emloft.net>,
	Yuchung Cheng <ycheng@...gle.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	David Howells <dhowells@...hat.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Neil Horman <nhorman@...driver.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Li Zefan <lizefan@...wei.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Alessandro Rubini <rubini@...dd.com>
Subject: [RFC] assign some address families for local use

Hello,

We are working on new protocols and we think that is useful to have some 
address protocol families index assigned for local use. So we will not have 
conflict every time a new protocol is included within the Linux kernel.
Doubt: index 27 and 28 are not assigned to any address family, can be 
explicitly assigned for local use?

We also thought to increase AF_MAX to 64 to avoid to modify it every time.
Doubt: array like af_family_key_strings (net/core/sock.c) will have some NULL 
pointer. I see that a string is specified also for index 27 and 28 even if 
there is not a protocol assigned for these. Is a NULL string a problem for 
these vectors? Typically is used in this way:

    af_family_clock_key_strings[newsk->sk_family]

So, if I set sk_family with an unassigned index I will have a NULL pointer and 
a DEBUG_LOCK_WARN_ON() from lockdep_init_map() (kernel/lockdep.c)

I attached to this email the patch that do these stuff.

-- 
Federico Vaga
View attachment "0001-include-linux-socket.h-assign-address-families-for-l.patch" of type "text/x-patch" (4305 bytes)