netdev - Re: [PATCH] fix mv643xx_eth.c lockdep violation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1368721294.3301.55.camel@edumazet-glaptop>
Date:	Thu, 16 May 2013 09:21:34 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Lennert Buytenhek <buytenh@...tstofly.org>, netdev@...r.kernel.org
Subject: Re: [PATCH] fix mv643xx_eth.c lockdep violation

On Thu, 2013-05-16 at 17:13 +0100, Russell King - ARM Linux wrote:

> It seems that txq_reclaim() takes the netif tx lock:
> 
>         __netif_tx_lock(nq, smp_processor_id());
> 
> in a context outside of softirq context, and thus is susceptible to
> deadlock should an interrupt occur.
> 
> Disable IRQs around the call to txq_deinit() to avoid this issue.

Hmm, I would use __netif_tx_lock_bh()/__netif_tx_unlock_bh() in
txq_reclaim() instead...



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html