netdev - [RFC] l2tp: avoid checksum offload for fragmented packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 May 2013 18:04:19 +0100
From:	Tom Parkin <tparkin@...alix.com>
To:	netdev@...r.kernel.org
Cc:	jchapman@...alix.com, Tom Parkin <tparkin@...alix.com>
Subject: [RFC] l2tp: avoid checksum offload for fragmented packets

UDP encapsulated L2TP data is currently subject to checksum errors if hardware
checksum offload is used, and the packet is fragmented.

This patch works around this issue by falling back to software checksumming if
the packet looks like it might fragment.

The problem with this approach (and the "RFC" part) is that we don't know how
big the IP header will be for the packet.  If we guess at the worst-case
scenario of 60b we can be sure to avoid checksum errors, but we may also be
using expensive software checksums in some cases where we don't really need
to.

Any suggestions on a better approach to solving this problem?  Should we be
using socket corking similar to the UDP code so that we can examine whether
the IP layer fragmented the packet after calling ip_append_data?

Tom Parkin (1):
  l2tp: avoid checksum offload for fragmented packets

 net/l2tp/l2tp_core.c |   53 ++++++++++++++++++++++++++++++--------------------
 1 file changed, 32 insertions(+), 21 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html