netdev - Re: [PATCH] sfc: Enable accelerated RFS on vlans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1368734447.2655.32.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Thu, 16 May 2013 21:00:47 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Andy Lutomirski <luto@...capital.net>
CC:	<netdev@...r.kernel.org>,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>
Subject: Re: [PATCH] sfc: Enable accelerated RFS on vlans

On Thu, 2013-05-16 at 12:45 -0700, Andy Lutomirski wrote:
> On Thu, May 16, 2013 at 11:38 AM, Ben Hutchings
> <bhutchings@...arflare.com> wrote:
> > On Fri, 2013-05-10 at 16:51 -0700, Andy Lutomirski wrote:
> >> As far as I know, the hardware doesn't support matching on both IP
> >> fields and vlan tag, but it can at least match on the vlan tag.
> >>
> >> Signed-off-by: Andy Lutomirski <luto@...capital.net>
> >> ---
> >>
> >> Tested on the OpenOnload version of the driver, but the patch is the same
> >> other than some offset.
> >
> > This looks correct, but I'll have to actually test it.  So I'll queue
> > this up and re-submit along with other sfc patches later on, OK?
> 
> Fine with me.  (Is there a combined vlan + IP filter that I don't know about?)

Not in current hardware.

> When you resubmit it, it might be worth fixing the blatant typo (vlan
> tag -> IP fields) in the description, though :/
[...]

Good point!

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html