netdev - Re: [PATCH] fix mv643xx_eth.c lockdep violation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130516.145706.1048942034798267653.davem@davemloft.net>
Date:	Thu, 16 May 2013 14:57:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	linux@....linux.org.uk
Cc:	eric.dumazet@...il.com, buytenh@...tstofly.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] fix mv643xx_eth.c lockdep violation

From: Russell King - ARM Linux <linux@....linux.org.uk>
Date: Thu, 16 May 2013 17:31:42 +0100

> From: Russell King <rmk+kernel@....linux.org.uk>
> Subject: [PATCH] NET: mv643xx_eth: avoid lockdep dump on interface down
> 
> When the interface is shutdown, the mv643xx_eth driver hits the following
> lockdep dump:
 ...
> It seems that txq_reclaim() takes the netif tx lock:
> 
>         __netif_tx_lock(nq, smp_processor_id());
> 
> in a context outside of softirq context, and thus is susceptible to
> deadlock should an interrupt occur.
> 
> Use __netif_tx_lock_bh()/__netif_tx_unlock_bh() instead.
> 
> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html