netdev - Re: [PATCH v2] bonding: allow TSO being set on bonding master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130516.150239.2187164031807939707.davem@davemloft.net>
Date:	Thu, 16 May 2013 15:02:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	mirqus@...il.com, netdev@...r.kernel.org, fubar@...ibm.com,
	maze@...gle.com, andy@...yhouse.net, therbert@...gle.com,
	ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH v2] bonding: allow TSO being set on bonding master

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 16 May 2013 10:34:53 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> In some situations, we need to disable TSO on bonding slaves.
> 
> bonding device automatically unset TSO in bond_fix_features(), and
> performance is not good because :
> 
> 1) We consume more cpu cycles.
> 
> 2) GSO segmentation has some bugs leading to out of order TCP packets
> if this segmentation is done before virtual device. This particular
> problem will be addressed in a separate patch.
> 
> This patch allows TSO being set/unset on the bonding master,
> so that GSO segmentation is done after bonding layer.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, but:

> +static inline netdev_features_t netdev_add_tso_features(netdev_features_t features,
> +	netdev_features_t mask)

I fixed the mask argument indentation when I commited this.

Thakns.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html