netdev - Re: [PATCH net-next v3] MPLS: Add limited GSO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEP_g=9JMk92eMaGrFs6pZv6AejcxfPSmOSXYi_UKrtZj3LwJA@mail.gmail.com>
Date:	Fri, 17 May 2013 14:42:01 -0700
From:	Jesse Gross <jesse@...ira.com>
To:	Simon Horman <horms@...ge.net.au>
Cc:	"dev@...nvswitch.org" <dev@...nvswitch.org>,
	netdev <netdev@...r.kernel.org>,
	Pravin B Shelar <pshelar@...ira.com>,
	Jarno Rajahalme <jarno.rajahalme@....com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Maciej Żenczykowski <maze@...gle.com>,
	Ben Hutchings <bhutchings@...arflare.com>
Subject: Re: [PATCH net-next v3] MPLS: Add limited GSO support

On Thu, May 16, 2013 at 11:50 PM, Simon Horman <horms@...ge.net.au> wrote:
> * Set skb->mac_len and skb->network_header to correspond to the
>   end of the L3 header, including the MPLS label stack.

I believe that the treatment of skb->mac_len is different from what
you are proposing in the OVS patch. I think this is because there is a
call to skb_reset_mac_len() in __skb_gso_segment() but it is somewhat
confusing. The GSO code is moving away from being able to reset all
header pointers and reparse the packet (obviously that's not possible
in the case of MPLS) so maybe we can just remove that call.

> A new NETIF_F_GRE_GSO feature is added for devices which support
> hardware MPLS GSO offload.  Currently no devices support this
> and MPLS GSO always falls back to software.

I assume that this is supposed to refer to MPLS and not GRE.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html