netdev - Re: [PATCH net-next] net: netdev_pick_tx: use get_xps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1368828197.3301.112.camel@edumazet-glaptop>
Date:	Fri, 17 May 2013 15:03:17 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	govind <govindarajulu90@...il.com>
Cc:	davem@...emloft.net, xiyou.wangcong@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: netdev_pick_tx: use get_xps_q if xps map
 is set

On Sat, 2013-05-18 at 01:20 +0530, govind wrote:

> I see. In ixgbe_select_queue we use __netdev_pick_tx only if packet is not
> FCOE & FIP.
> 
> If you see
> bnx2x_select_queue in drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c, line 1832
> and mlx4_en_select_queue in drivers/net/ethernet/mellanox/mlx4/en_tx.c, line 547.
> we cannot have xps working with these drivers.
> 
> This needs to be fixed by replacing __skb_tx_hash with __netdev_pick_tx. Am i 
> correct?

Yes, this seems better.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html