netdev - Re: [PATCH 2/5] net: davinci_emac: remove unwanted header inclusion and sort the alphabetically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8vWLWXL7WP3dzKXM0yFAkoU4UxfaqJ4E1t0gQhRp8zj-w@mail.gmail.com>
Date:	Fri, 17 May 2013 10:23:16 +0530
From:	Prabhakar Lad <prabhakar.csengg@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	DLOS <davinci-linux-open-source@...ux.davincidsp.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jiri Kosina <trivial@...nel.org>, netdev@...r.kernel.org,
	Mugunthan V N <mugunthanvnm@...com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/5] net: davinci_emac: remove unwanted header inclusion
 and sort the alphabetically

Hi Sergei,

Thanks for the review.

On Fri, May 17, 2013 at 12:25 AM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> On 16-05-2013 11:30, Lad Prabhakar wrote:
>
>> From: Lad, Prabhakar <prabhakar.csengg@...il.com>
>
>
>> This patch removes unwanted header inclusion
>
>
>    Why are they unwanted?
>
The driver builds without this includes.

This is arguable, if I would have added a new driver with the only
#includes which were required to build thats accepted. But when I remove
unnecessary #includes from the existing drivers that's not acceptable ?

This applies to rest of the similar patches in the series.

>> and sorts them alphabetically
>
>
>    In the subject you typed "the" instead of "them".
>
Hmm carry forwarded this copy paste error every where will fix it in V2.

Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html