netdev - Re: [PATCH] dev: remove duplicate 'skb->dev = dev' in dev_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1368797952.3301.85.camel@edumazet-glaptop>
Date:	Fri, 17 May 2013 06:39:12 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] dev: remove duplicate 'skb->dev = dev' in
 dev_forward_skb()

On Fri, 2013-05-17 at 11:36 +0200, Nicolas Dichtel wrote:
> This was added by commit 59b9997baba5 (Revert "net: maintain namespace
> isolation between vlan and real device").
> In fact, before the initial commit - the one that is reverted -, this
> statement was not present.
> 'skb->dev = dev' is already done in eth_type_trans(), which is call just
> after.
> 
> Spotted-by: Alain Ritoux <alain.ritoux@...nd.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> ---

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html