netdev - Re: [PATCHv6 0/3] Add support for velocity network driver on platform devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130517.173644.1877140985770026320.davem@davemloft.net>
Date:	Fri, 17 May 2013 17:36:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	linux@...sktech.co.nz
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	romieu@...zoreil.com, netdev@...r.kernel.org
Subject: Re: [PATCHv6 0/3] Add support for velocity network driver on
 platform devices

From: David Miller <davem@...emloft.net>
Date: Fri, 17 May 2013 14:19:38 -0700 (PDT)

> 
> Series applied, thanks.

I'm reverting this, you're not using the correct types for the PM
functions you're hooking up.

drivers/net/ethernet/via/via-velocity.c:3238:8: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/ethernet/via/via-velocity.c:3238:8: warning: (near initialization for ‘velocity_pm_ops.suspend’) [enabled by default]
drivers/net/ethernet/via/via-velocity.c:3238:8: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/ethernet/via/via-velocity.c:3238:8: warning: (near initialization for ‘velocity_pm_ops.freeze’) [enabled by default]
drivers/net/ethernet/via/via-velocity.c:3238:8: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/ethernet/via/via-velocity.c:3238:8: warning: (near initialization for ‘velocity_pm_ops.poweroff’) [enabled by default]