netdev - Re: [PATCH] r8169: fix offloaded tx checksum for small packets.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130518101032.GB20930@electric-eye.fr.zoreil.com>
Date:	Sat, 18 May 2013 12:10:32 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Hayes Wang <hayeswang@...ltek.com>,
	Stefan Bader <stefan.bader@...onical.com>,
	Holger Hoffstätte 
	<holger.hoffstaette@...glemail.com>
Subject: Re: [PATCH] r8169: fix offloaded tx checksum for small packets.

Ben Hutchings <bhutchings@...arflare.com> :
[...]
> skb_checksum_help() can fail, though it is unlikely for such a short
> packet.  So I think this should be:
> 
> 			return skb_checksum_help(skb) == 0 && rtl_skb_pad(skb);

Will do. I don't have consistent test results anyway. :o(

Thanks.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html