netdev - Re: [PATCH net-next v3] MPLS: Add limited GSO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130520032049.GG16811@verge.net.au>
Date:	Mon, 20 May 2013 12:20:49 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Jesse Gross <jesse@...ira.com>
Cc:	"dev@...nvswitch.org" <dev@...nvswitch.org>,
	netdev <netdev@...r.kernel.org>,
	Pravin B Shelar <pshelar@...ira.com>,
	Jarno Rajahalme <jarno.rajahalme@....com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Maciej Żenczykowski <maze@...gle.com>,
	Ben Hutchings <bhutchings@...arflare.com>
Subject: Re: [PATCH net-next v3] MPLS: Add limited GSO support

On Fri, May 17, 2013 at 02:42:01PM -0700, Jesse Gross wrote:
> On Thu, May 16, 2013 at 11:50 PM, Simon Horman <horms@...ge.net.au> wrote:
> > * Set skb->mac_len and skb->network_header to correspond to the
> >   end of the L3 header, including the MPLS label stack.
> 
> I believe that the treatment of skb->mac_len is different from what
> you are proposing in the OVS patch. I think this is because there is a
> call to skb_reset_mac_len() in __skb_gso_segment() but it is somewhat
> confusing. The GSO code is moving away from being able to reset all
> header pointers and reparse the packet (obviously that's not possible
> in the case of MPLS) so maybe we can just remove that call.

I agree that is likely. I will see about making it so.

> 
> > A new NETIF_F_GRE_GSO feature is added for devices which support
> > hardware MPLS GSO offload.  Currently no devices support this
> > and MPLS GSO always falls back to software.
> 
> I assume that this is supposed to refer to MPLS and not GRE.

Sorry about that, yes, I meant to type MPLS.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html