netdev - Re: [PATCH net-next] arp: flush arp cache on IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 May 2013 13:46:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	timo.teras@....fi
Cc:	netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH net-next] arp: flush arp cache on IFF_NOARP change

From: Timo Teräs <timo.teras@....fi>
Date: Mon, 20 May 2013 16:29:01 +0300

> IFF_NOARP affects what kind of neighbor entries are created
> (nud NOARP or nud INCOMPLETE). If the flag changes, flush the arp
> cache to refresh all entries.
> 
> Signed-off-by: Timo Teräs <timo.teras@....fi>
> Cc: Patrick McHardy <kaber@...sh.net>

This patch makes no sense at all.

The state bit in ->priv_flags is a boolean stating whether the
notified should do something or not.

But you're setting it to match what IFF_NOARP is.

You should set it any time IFF_NOARP _changes_, and then clear
the bit when the notifier clears the neighbour entries.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html