netdev - Re: [PATCH net-next] tcp: md5: remove spinlock usage in fast path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130520.140118.176987219677786436.davem@davemloft.net>
Date:	Mon, 20 May 2013 14:01:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, herbert@...dor.apana.org.au
Subject: Re: [PATCH net-next] tcp: md5: remove spinlock usage in fast path

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 20 May 2013 09:52:26 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> TCP md5 code uses per cpu variables but protects access to them with
> a shared spinlock, which is a contention point.
> 
> [ tcp_md5sig_pool_lock is locked twice per incoming packet ]
> 
> Makes things much simpler, by allocating crypto structures once, first
> time a socket needs md5 keys, and not deallocating them as they are
> really small.
> 
> Next step would be to allow crypto allocations being done in a NUMA
> aware way.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Looks good, applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html