netdev - Re: [PATCH net-next] net-bnx2x: dont reload on GRO change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130520.001703.3222910244436114.davem@davemloft.net>
Date:	Mon, 20 May 2013 00:17:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dmitry@...adcom.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, eilong@...adcom.com
Subject: Re: [PATCH net-next] net-bnx2x: dont reload on GRO change

From: "Dmitry Kravkov" <dmitry@...adcom.com>
Date: Sat, 18 May 2013 21:36:07 +0000

>> -----Original Message-----
>> From: Eric Dumazet [mailto:eric.dumazet@...il.com]
>> Sent: Saturday, May 18, 2013 8:15 PM
>> To: David Miller
>> Cc: netdev; Dmitry Kravkov; Eilon Greenstein
>> Subject: [PATCH net-next] net-bnx2x: dont reload on GRO change
>> 
>> From: Eric Dumazet <edumazet@...gle.com>
>> 
>> bnx2x_set_features() forces a driver reload if GRO setting is changed.
>> 
>> A reload makes the ethernet port unresponsive for about 5 seconds.
>> 
>> This is not needed in the common case LRO is enabled, as LRO
>> (TPA_ENABLE_FLAG) has precedence over GRO (GRO_ENABLE_FLAG)
>> 
>> Tested:
>>  Verified that "ethtool -K eth0 gro {on|off}" doesn't blackout
>>  the NIC anymore
>> 
>> Google-Bug-Id: 8440442
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
...
> Looks good! Thanks, Eric
> 
> Acked-by: Dmitry Kravkov <dmitry@...adcom.com>
> 

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html