netdev - Re: [PATCH 1/5] drivers: net: usb: rtl8150: moving constant and structure definitions out of rtl8150.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1369061360.4616.0.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Mon, 20 May 2013 15:49:20 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Petko Manolov <petkan@...leusys.com>
CC:	David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/5] drivers: net: usb: rtl8150: moving constant and
 structure definitions out of rtl8150.c

On Sat, 2013-05-18 at 23:20 +0300, Petko Manolov wrote:
> From: Petko Manolov <petkan@...leusys.com>
> 
> Moving constant and structure definitions out of rtl8150.c;
> 
> Signed-off-by: Petko Manolov <petkan@...leusys.com>
> ---
>  drivers/net/usb/rtl8150.c |  121 +----------------------------------
>  1 file changed, 2 insertions(+), 119 deletions(-)
> 
> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> index a491d3a..7d1897b 100644
> --- a/drivers/net/usb/rtl8150.c
> +++ b/drivers/net/usb/rtl8150.c
> @@ -17,132 +17,15 @@
>  #include <linux/usb.h>
>  #include <asm/uaccess.h>
>  
> +#include "rtl8150.h"
[...]

Now how is this driver going to compile, when rtl8150.h is only added by
the next patch?!

You need to squash these first 2 together, so that the driver can be
compiled after each step.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html