netdev - Re: [PATCH 0/5] perf: net_dropmonitor: Make it work and make it fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130521161209.GC3613@neilslaptop.think-freely.org>
Date:	Tue, 21 May 2013 12:12:09 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] perf: net_dropmonitor: Make it work and make it fast

On Tue, May 21, 2013 at 02:54:00PM +0100, Ben Hutchings wrote:
> On Tue, 2013-05-21 at 09:33 -0400, Neil Horman wrote:
> > On Tue, May 21, 2013 at 01:42:56AM +0100, Ben Hutchings wrote:
> > > Somewhat surprisingly, the net_dropmonitor reporting script doesn't work
> > > at all.  This series fixes it and then makes it slightly more efficient.
> > > 
> > > Ben.
> > > 
> > It worked fine when I first submitted it.  I wonder if there was a paramter
> > order change at some point that I wasn't CC'ed on.
> 
> The parameter order for the trace event changed in 2.6.39, but that was
> before this script went in.
> 
> Ben.
> 
Yeah, thats how this happened.  I posted right before 2.6.39, which was around
July 4th:
https://lkml.org/lkml/2011/7/4/273

So I posted it, and shortly thereafter the perf infrastructure changed.  Acme
didnt actually pull the patch in until Well into August, and so it was borked
from there.  I never noticed as I had been using the netlink based utility since
that time.

Thanks for catching this!
Neil

> > Either way, this all looks good.  Thanks Ben.
> > 
> > Acked-by: Neil Horman <nhorman@...driver.com>
> > 
> > > Ben Hutchings (5):
> > >   perf: net_dropmonitor: Fix trace parameter order
> > >   perf: net_dropmonitor: Fix symbol-relative addresses
> > >   perf: net_dropmonitor: Do not assume ordering of dictionaries
> > >   perf: net_dropmonitor: Use bisection in symbol lookup
> > >   perf: net_dropmonitor: Remove progress indicator
> > > 
> > >  tools/perf/scripts/python/net_dropmonitor.py |   39 ++++++++++++++------------
> > >  1 file changed, 21 insertions(+), 18 deletions(-)
> > > 
> > > 
> > 
> > 
> 
> -- 
> Ben Hutchings
> friends: People who know you well, but like you anyway.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html