netdev - Re: [Xen-devel] [PATCH net-next 2/2] xen-netfront: split event channels feature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130521170726.GA18489@zion.uk.xensource.com>
Date:	Tue, 21 May 2013 18:07:26 +0100
From:	Wei Liu <wei.liu2@...rix.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	Wei Liu <wei.liu2@...rix.com>,
	David Vrabel <david.vrabel@...rix.com>,
	<xen-devel@...ts.xen.org>, <netdev@...r.kernel.org>,
	<ian.campbell@...rix.com>
Subject: Re: [Xen-devel] [PATCH net-next 2/2] xen-netfront: split event
 channels feature support

On Tue, May 21, 2013 at 12:28:25PM -0400, Konrad Rzeszutek Wilk wrote:
> On Tue, May 21, 2013 at 02:41:49PM +0100, Wei Liu wrote:
> > On Tue, May 21, 2013 at 02:39:01PM +0100, David Vrabel wrote:
> > [...]
> > > > +	info->rx_evtchn = info->tx_evtchn;
> > > > +	info->rx_irq = info->tx_irq = err;
> > > > +	dev_info(&info->xbdev->dev,
> > > > +		 "single event channel, evtchn = %d, irq = %d\n",
> > > > +		 info->tx_evtchn, info->tx_irq);
> > > 
> > > This message is pointless chatter as the information is available
> > > elsewhere.  Please remove.
> > > 
> > 
> > Do you mean /proc/interrupt by "elsewhere"? Information there doesn't
> > give you irq<->evtchn mapping info.
> 
> If you really want to, that should be implemented via an DebugFS entry that can
> be driven from drivers/xen/events.c. As the events.c is the generic code that sets
> up the Xen events, pirqs, ipis, <-> Linux IRQs.

I mainly focus on upstreaming all necessary features for a new Xen
network baseline, so I would rather not touch other files.

I will delete these dev_info, they don't seem to be critical anyway.


Wei.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html