netdev - Re: [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1369124929.29989.0.camel@lb-tlvb-eilong.il.broadcom.com>
Date:	Tue, 21 May 2013 11:28:49 +0300
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	"Or Gerlitz" <or.gerlitz@...il.com>
cc:	"Eliezer Tamir" <eliezer.tamir@...ux.intel.com>,
	"Dave Miller" <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	"Jesse Brandeburg" <jesse.brandeburg@...el.com>,
	"Don Skidmore" <donald.c.skidmore@...el.com>,
	e1000-devel@...ts.sourceforge.net,
	"Willem de Bruijn" <willemb@...gle.com>,
	"Andi Kleen" <andi@...stfloor.org>, HPA <hpa@...or.com>,
	"Eliezer Tamir" <eliezer@...ir.org.il>
Subject: Re: [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

On Tue, 2013-05-21 at 11:21 +0300, Or Gerlitz wrote:
> On Tue, May 21, 2013 at 10:06 AM, Eilon Greenstein <eilong@...adcom.com> wrote:
> > Or - at least for the bnx2x, it is easy to add support for this new ndo.
> 
> Do you understand what's the equivalent of that mysterious module
> param for your driver/HW - or you just copied and pasted that black
> magic code?
> 

The module parameter is not the interesting part of this patch. It is
clear that unloading the module while this sort of traffic is running is
not safe and the alternative of adding a reference count or something
similar sounds too costly (after all, this patch is about performance).
I just played with it to get a feel of the latency improvement - I did
not try unloading the module during traffic so I do not care about the
module parameter part right now. I agree that the unload should be
looked into - but the general concept is great and it is a very nice
improvement.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html