netdev - Re: [PATCH net-next 1/4] bnx2x: Add Private Flags Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1369238897.2670.11.camel@bwh-desktop.uk.level5networks.com>
Date:	Wed, 22 May 2013 17:08:17 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Yuval Mintz <yuvalmin@...adcom.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<ariele@...adcom.com>, <eilong@...adcom.com>
Subject: Re: [PATCH net-next 1/4] bnx2x: Add Private Flags Support

On Wed, 2013-05-22 at 15:22 +0300, Yuval Mintz wrote:
> Utilize ethtool's callback `get_priv_flags' - shed more light on the
> feasibility of devices as storage interfaces.
[...]
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
[...]
> +static const char bnx2x_private_arr[BNX2X_PRI_FLAG_LEN][ETH_GSTRING_LEN] = {
> +	"iSCSI offload support ",
> +	"FCoE offload support  ",
> +	"Storage only interface"
> +};
[...]

No trailing spaces, please.  If you don't like the way private flags are
printed by ethtool, send a patch for ethtool.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html