netdev - Re: [PATCH v2 nf-next] netfilter: conntrack: remove the central spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1369255104.2143.108.camel@joe-AO722>
Date:	Wed, 22 May 2013 13:38:24 -0700
From:	Joe Perches <joe@...ches.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Pablo Neira Ayuso <pablo@...filter.org>,
	netfilter-devel@...r.kernel.org, netdev <netdev@...r.kernel.org>,
	Tom Herbert <therbert@...gle.com>,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH v2 nf-next] netfilter: conntrack: remove the central
 spinlock

On Wed, 2013-05-22 at 13:16 -0700, Eric Dumazet wrote:
> On Wed, 2013-05-22 at 12:57 -0700, Joe Perches wrote:
> > It might also be nice to mark it if ever more than a u16
> > brace/flock/coven/cluster worth of cpus become feasible
> > as it seems int is used almost everywhere else.
> 
> It seems Linus hates cpu_t or whatever_t

Go figure.

> Thats why we have u16 everywhere to code cpu numbers, and why we use
> "unsigned long" for jiffies.

u16 for cpu is hardly used at all.

$ git grep -E "^\s*\w+\s+cpu\s*;" | cut -f2- -d":" | \
  sed -r -e 's/^\s+//g' -e 's/\s+/ /g' -e 's/;.*//' | \
  sort | uniq -c | sort -rn
    569 int cpu
     29 return cpu
     28 __u32 cpu
     14 u32 cpu
      7 unsigned cpu
      5 u16 cpu
      4 cpuid_t cpu
      3 uint32_t cpu
      2 __u8 cpu
      2 u64 cpu
      2 s32 cpu
      2 long cpu
      1 u8 cpu
      1 __u16 cpu
      1 struct cpu
      1 short cpu
      1 __le32 cpu
      1 geo_cpu_t cpu

> So far, I believe linux supports at most 4096 cpus.

I believe that as well.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html