netdev - Re: [PATCH 11/19] net/ethernet/broadcom/tg3: Use module_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <519C0FD8.80705@broadcom.com>
Date:	Tue, 21 May 2013 17:22:48 -0700
From:	"Nithin Nayak Sujir" <nsujir@...adcom.com>
To:	"Peter Huewe" <peterhuewe@....de>
cc:	"David S. Miller" <davem@...emloft.net>,
	"Michael Chan" <mchan@...adcom.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/19] net/ethernet/broadcom/tg3: Use
 module_pci_driver to register driver



On 05/21/2013 03:58 PM, Peter Huewe wrote:
> Removing some boilerplate by using module_pci_driver instead of calling
> register and unregister in the otherwise empty init/exit functions.
>
> Signed-off-by: Peter Huewe <peterhuewe@....de>
> ---
>   drivers/net/ethernet/broadcom/tg3.c | 13 +------------
>   1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index fb06aa1..4f0e3fe 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -17804,15 +17804,4 @@ static struct pci_driver tg3_driver = {
>   	.driver.pm	= &tg3_pm_ops,
>   };
>
> -static int __init tg3_init(void)
> -{
> -	return pci_register_driver(&tg3_driver);
> -}
> -
> -static void __exit tg3_cleanup(void)
> -{
> -	pci_unregister_driver(&tg3_driver);
> -}
> -
> -module_init(tg3_init);
> -module_exit(tg3_cleanup);
> +module_pci_driver(tg3_driver);
>

Acked-by: Nithin Nayak Sujir <nsujir@...adcom.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html