netdev - Re: [PATCH next-next v4 1/2] net: Use 16bits for inner_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.GSO.2.00.1305220923130.11532@git.silcnet.org>
Date:	Wed, 22 May 2013 09:25:16 +0200 (CEST)
From:	Pekka Riikonen <priikone@....fi>
To:	Simon Horman <horms@...ge.net.au>
cc:	dev@...nvswitch.org, netdev@...r.kernel.org,
	Jesse Gross <jesse@...ira.com>,
	Pravin B Shelar <pshelar@...ira.com>,
	jarno.rajahalme@....com, Eric Dumazet <eric.dumazet@...il.com>,
	Maciej Żenczykowski <maze@...gle.com>
Subject: Re: [PATCH next-next v4 1/2] net: Use 16bits for inner_*_headers
 fields of struct skbuff

On Wed, 22 May 2013, Simon Horman wrote:

> include/linux/skbuff.h | 63 +++++++-------------------------------------------
> 1 file changed, 8 insertions(+), 55 deletions(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 2e0ced1..3791615 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -509,9 +509,9 @@ struct sk_buff {
> 		__u32		reserved_tailroom;
> 	};
>
> -	sk_buff_data_t		inner_transport_header;
> -	sk_buff_data_t		inner_network_header;
> -	sk_buff_data_t		inner_mac_header;
> +	__u16			inner_transport_header;
> +	__u16			inner_network_header;
> +	__u16			inner_mac_header;
> 	sk_buff_data_t		transport_header;
> 	sk_buff_data_t		network_header;
> 	sk_buff_data_t		mac_header;
>
Why not take one more step and use 16-bit fields for the other header 
fields too: transport_header, network_header and mac_header?

 	Pekka
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html