netdev - Re: [PATCH] bonding: add synchronize_net() after netdev_rx_handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1369274648.3301.378.camel@edumazet-glaptop>
Date:	Wed, 22 May 2013 19:04:08 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	dingtianhong <dingtianhong@...wei.com>
Cc:	Jay Vosburgh <fubar@...ibm.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Netdev <netdev@...r.kernel.org>, Li Zefan <lizefan@...wei.com>
Subject: Re: [PATCH] bonding: add synchronize_net() after
 netdev_rx_handler_unregister

On Thu, 2013-05-23 at 09:57 +0800, dingtianhong wrote:
> commit 00cfec3 (net: add a synchronize_net() in netdev_rx_handler_unregister())
> add a synchronize_net() in netdev_rx_handler_unregister() to guarantee the
> rx_handler is NULL when rx_handler_data is a non NULL in rcu_read_lock().
> 
> so the caller should not use netdev_rx_handler_unregister in atomic as it may
> schedule and sleep, the bonding release met the problem.
> 
> the commit fcd99434f (bonding: get netdev_rx_handler_unregister out of locks)
> fix the bug in bond release, but there is no action to guarantee the
> rx_handler_data is NULL when bond release, so add synchronize_net() behind
> netdev_rx_handler_unregister() to guarantee it.
> 
> This patch adds more comments to netdev_rx_handler_unregister(), as its more
> reasonable.
> 
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
> ---
>  drivers/net/bonding/bond_main.c | 2 ++
>  net/core/dev.c                  | 3 +++
>  2 files changed, 5 insertions(+)


I NACK this patch. This makes absolutely no sense to me.




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html