netdev - Re: [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130523.121037.84357412382839522.davem@davemloft.net>
Date:	Thu, 23 May 2013 12:10:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gururaja.hebbar@...com
Cc:	mugunthanvnm@...com, netdev@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org, linux-omap@...r.kernel.org,
	benoit.cousson@...aro.orgm, paul@...an.com
Subject: Re: [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

From: "Hebbar, Gururaja" <gururaja.hebbar@...com>
Date: Thu, 23 May 2013 11:28:38 +0000

> On Thu, May 23, 2013 at 12:27:41, David Miller wrote:
>> From: Mugunthan V N <mugunthanvnm@...com>
>> Date: Tue, 21 May 2013 15:24:58 +0530
>> 
>> > +		priv->pins_default = pinctrl_lookup_state(priv->pinctrl,
>> > +						PINCTRL_STATE_DEFAULT);
>> 
>> This is not indented correctly.
>> 
>> Argument on the second, and subsequent, lines of a function call
>> must start at the first column after the openning parenthesis of
>> the function call itself.
> 
> Well, if I am correct, doing so will make the line cross 80 character limit.
> If you could (please I ask), can you let me know how it can be handled in 
> above situation. I will make the changes/corrections and re-send it.
> 
> Thanks a lot in advance.

Avoid the deep indentation by coding the basic block into a helper
function.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html