netdev - Re: [PATCH net-next] sch_tbf: segment too big GSO packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130523.000714.1429138700064965816.davem@davemloft.net>
Date:	Thu, 23 May 2013 00:07:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jiri@...nulli.us
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, ben@...adent.org.uk
Subject: Re: [PATCH net-next] sch_tbf: segment too big GSO packets

From: Jiri Pirko <jiri@...nulli.us>
Date: Tue, 21 May 2013 22:39:45 +0200

> Tue, May 21, 2013 at 08:16:46PM CEST, eric.dumazet@...il.com wrote:
>>From: Eric Dumazet <edumazet@...gle.com>
>>
>>If a GSO packet has a length above tbf burst limit, the packet
>>is currently silently dropped.
>>
>>Current way to handle this is to set the device in non GSO/TSO mode, or
>>setting high bursts, and its sub optimal.
>>
>>We can actually segment too big GSO packets, and send individual
>>segments as tbf parameters allow, allowing for better interoperability.
>>
>>Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>>Cc: Ben Hutchings <ben@...adent.org.uk>
>>Cc: Jiri Pirko <jiri@...nulli.us>
>>Cc: Jamal Hadi Salim <jhs@...atatu.com>
> 
> Reviewed-by: Jiri Pirko <jiri@...nulli.us>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html