netdev - Re: [PATCH ipsec] xfrm: properly handle invalid states as an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130523.012033.2025528481150126076.davem@davemloft.net>
Date:	Thu, 23 May 2013 01:20:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	timo.teras@....fi
Cc:	netdev@...r.kernel.org, roy.qing.li@...il.com,
	steffen.klassert@...unet.com
Subject: Re: [PATCH ipsec] xfrm: properly handle invalid states as an error

From: Timo Teräs <timo.teras@....fi>
Date: Wed, 22 May 2013 14:40:47 +0300

> The error exit path needs err explicitly set. Otherwise it
> returns success and the only caller, xfrm_output_resume(),
> would oops in skb_dst(skb)->ops derefence as skb_dst(skb) is
> NULL.
> 
> Bug introduced in commit bb65a9cb (xfrm: removes a superfluous
> check and add a statistic).
> 
> Signed-off-by: Timo Teräs <timo.teras@....fi>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html