netdev - Re: [PATCH] bridge: netfilter: using strlcpy() instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <519DF601.1010400@asianux.com>
Date:	Thu, 23 May 2013 18:57:05 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Pablo Neira Ayuso <pablo@...filter.org>
CC:	bart.de.schuymer@...dora.be, kaber@...sh.net,
	stephen@...workplumber.org, David Miller <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org,
	coreteam@...filter.org, bridge@...ts.linux-foundation.org,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] bridge: netfilter: using strlcpy() instead of strncpy()

On 05/23/2013 06:56 PM, Pablo Neira Ayuso wrote:
> On Fri, May 17, 2013 at 04:07:22PM +0800, Chen Gang wrote:
>> > 
>> > 'name' has already set all zero when it is defined, so not need let
>> > strncpy() to pad it again.
>> > 
>> > 'name' is a string, better always let is NUL terminated, so use
>> > strlcpy() instead of strncpy().
> Applied, thanks.
> 
> 

Thank you too.

-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html