netdev - Re: [PATCH] bonding: add synchronize_net() after netdev_rx_handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <519D7452.8050405@huawei.com>
Date:	Thu, 23 May 2013 09:43:46 +0800
From:	dingtianhong <dingtianhong@...wei.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	Jay Vosburgh <fubar@...ibm.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Netdev <netdev@...r.kernel.org>, Li Zefan <lizefan@...wei.com>
Subject: Re: [PATCH] bonding: add synchronize_net() after netdev_rx_handler_unregister

On 2013/5/23 2:30, Sergei Shtylyov wrote:
> Hello.
> 
> On 22-05-2013 12:42, dingtianhong wrote:
> 
>> commit 00cfec3748 (net: add a synchronize_net() ...) add a synchronize_net()
> 
>    Please specify complete summary line of this commit.
> 

ok, I will modify and send again, just tell me your opinion, thanks.

>> in netdev_rx_handler_unregister() to guarantee the rx_handler  is NULL when
>> rx_handler_data is a non NULL in rcu_read_lock().
>>
>> so the caller should not use netdev_rx_handler_unregister in atomic as it may
>> schedule and sleep, the commit fcd99434f
> 
>    You forgot to specify the summary line of this commit.
> 
>> fix the bug in bond release, but the
>> problem is no action to guarantee the rx_handler_data is NULL when bond release,
>> so add synchronize_net() and fix it.
> 
>> This patch adds more comments to netdev_rx_handler_unregister().
> 
>> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
> 
> WBR, Sergei
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html