netdev - Re: [PATCH] be2net: bug fix on returning an invalid nic descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130524021218.GA11660@weiyang.vnet.ibm.com>
Date:	Fri, 24 May 2013 10:12:18 +0800
From:	Wei Yang <weiyang@...ux.vnet.ibm.com>
To:	David Miller <davem@...emloft.net>
Cc:	weiyang@...ux.vnet.ibm.com, sathya.perla@...lex.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] be2net: bug fix on returning an invalid nic descriptor

On Thu, May 23, 2013 at 06:57:04PM -0700, David Miller wrote:
>From: Wei Yang <weiyang@...ux.vnet.ibm.com>
>Date: Thu, 23 May 2013 09:58:22 +0800
>
>> In function be_get_nic_desc(), it will go through the descriptor array
>> returned from f/w. By comparing the desc_type field, it determines whether
>> there is a nic descriptor in the array or not. In the case of no nic
>> descriptor, this function should return NULL.
>> 
>> The code may return an invalide descriptor, when there is no nic descriptor
>> in the array and the desc_count is less than MAX_RESOURCE_DESC. In this case,
>> even there is no nic descriptor, it will still return the lase descriptor
>> since the i doesn't equal to MAX_RESOURCE_DESC.
>> 
>> This patch fix this issue by returning the descriptor when find it and return
>> NULL for other cases.
>> 
>> Signed-off-by: Wei Yang <weiyang@...ux.vnet.ibm.com>
>> Reviewed-by: Gavin Shan <shangw@...ux.vnet.ibm.com>
>> Reviewed-by: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
>
>Applied.

Got it, Thanks~

-- 
Richard Yang
Help you, Help me

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html