netdev - Re: [PATCH] tcp: xps: fix reordering issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130523.182939.1656578741039330554.davem@davemloft.net>
Date:	Thu, 23 May 2013 18:29:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, therbert@...gle.com, ycheng@...gle.com,
	ncardwell@...gle.com
Subject: Re: [PATCH] tcp: xps: fix reordering issues

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 23 May 2013 10:44:20 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> commit 3853b5841c01a ("xps: Improvements in TX queue selection")
> introduced ooo_okay flag, but the condition to set it is slightly wrong.
> 
> In our traces, we have seen ACK packets being received out of order,
> and RST packets sent in response.
> 
> We should test if we have any packets still in host queue.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html