lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130523.183817.86513902587870539.davem@davemloft.net>
Date:	Thu, 23 May 2013 18:38:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	horms@...ge.net.au
Cc:	dev@...nvswitch.org, netdev@...r.kernel.org, jesse@...ira.com,
	pshelar@...ira.com, jarno.rajahalme@....com,
	eric.dumazet@...il.com, maze@...gle.com
Subject: Re: [PATCH next-next v4 1/2] net: Use 16bits for inner_*_headers
 fields of struct skbuff

From: Simon Horman <horms@...ge.net.au>
Date: Wed, 22 May 2013 15:57:15 +0900

> @@ -509,9 +509,9 @@ struct sk_buff {
>  		__u32		reserved_tailroom;
>  	};
>  
> -	sk_buff_data_t		inner_transport_header;
> -	sk_buff_data_t		inner_network_header;
> -	sk_buff_data_t		inner_mac_header;
> +	__u16			inner_transport_header;
> +	__u16			inner_network_header;
> +	__u16			inner_mac_header;
>  	sk_buff_data_t		transport_header;
>  	sk_buff_data_t		network_header;
>  	sk_buff_data_t		mac_header;

As Pekka suggested, let's try to convert them allto __u16.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ