netdev - Re: [PATCHv3 1/6] net: Add EMAC ethernet driver found on Allwinner A10 SoC's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <519F6128.9060608@elopez.com.ar>
Date:	Fri, 24 May 2013 09:46:32 -0300
From:	Emilio López <emilio@...pez.com.ar>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
CC:	davem@...emloft.net, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stefan Roese <sr@...x.de>,
	Florian Fainelli <florian@...nwrt.org>,
	kevin@...winnertech.com, sunny@...winnertech.com,
	shuge@...winnertech.com
Subject: Re: [PATCHv3 1/6] net: Add EMAC ethernet driver found on Allwinner
 A10 SoC's

El 24/05/13 06:23, Maxime Ripard escribió:
> From: Stefan Roese <sr@...x.de>
> 
> The Allwinner A10 has an ethernet controller that seem to be developped
> internally by them.
> 
> The exact feature set of this controller is unknown, since there is no
> public documentation for this IP, and this driver is mostly the one
> published by Allwinner that has been heavily cleaned up.
> 
> Signed-off-by: Stefan Roese <sr@...x.de>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> ---

(snip)

> +
> +config SUN4I_EMAC
> +        tristate "Allwinner A10 EMAC support"
> +	depends on ARCH_SUNXI
> +	depends on OF
> +	select CRC32
> +	select NET_CORE
> +	select MII
> +	select REGULATOR_FIXED_VOLTAGE
> +        ---help---
> +          Support for Allwinner A10 EMAC ethernet driver.
> +
> +          To compile this driver as a module, choose M here.  The module
> +          will be called sun4i-emac.
> +

You also need to select REGULATOR when you select REGULATOR_FIXED_VOLTAGE

I have attached a fixup patch you can use with git autosquash

Cheers,

Emilio

View attachment "fixup-regulator.patch" of type "text/x-diff" (736 bytes)