netdev - Re: [PATCH] ip_tunnel: fix kernel panic with icmp_dest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130525.232708.324081198009097189.davem@davemloft.net>
Date:	Sat, 25 May 2013 23:27:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	daniel.petre@...-rds.ro, netdev@...r.kernel.org
Subject: Re: [PATCH] ip_tunnel: fix kernel panic with icmp_dest_unreach

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 24 May 2013 08:49:58 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Daniel Petre reported crashes in icmp_dst_unreach() with following call
> graph:
 ...
> Daniel found a similar problem mentioned in 
>  http://lkml.indiana.edu/hypermail/linux/kernel/1007.0/00961.html
> 
> And indeed this is the root cause : skb->cb[] contains data fooling IP
> stack.
> 
> We must clear IPCB in ip_tunnel_xmit() sooner in case dst_link_failure()
> is called. Or else skb->cb[] might contain garbage from GSO segmentation
> layer.
> 
> A similar fix was tested on linux-3.9, but gre code was refactored in
> linux-3.10. I'll send patches for stable kernels as well.
> 
> Many thanks to Daniel for providing reports, patches and testing !
> 
> Reported-by: Daniel Petre <daniel.petre@...-rds.ro>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks a lot everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html