lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 May 2013 23:42:48 -0700 (PDT) From: David Miller <davem@...emloft.net> To: mugunthanvnm@...com Cc: netdev@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org, linux-omap@...r.kernel.org, benoit.cousson@...aro.org, paul@...an.com, gururaja.hebbar@...com Subject: Re: [net-next PATCH v2 1/6] net: cpsw: enhance pinctrl support From: Mugunthan V N <mugunthanvnm@...com> Date: Thu, 23 May 2013 18:00:23 +0530 > From: Hebbar Gururaja <gururaja.hebbar@...com> > > Amend cpsw controller to optionally take a pin control handle and set > the state of the pins to: > > - "default" on boot, resume > - "sleep" on suspend() > > This should make it possible to optimize energy usage for the pins > for the suspend/resume cycle. > > If any of the above pin states are missing in dt, a warning message > about the missing state is displayed. > If certain pin-states are not available, to remove this warning message > pass respective state name with null phandler. > > Signed-off-by: Hebbar Gururaja <gururaja.hebbar@...com> > Signed-off-by: Mugunthan V N <mugunthanvnm@...com> This still needs some work: > + /* > + * Since we continue even when pinctrl node is not found, > + * Invalidate pins as not available. This is to make sure that > + * IS_ERR(pins_xxx) results in failure when used. > + */ The second, third, fourth, and fifth lines are not tabbed correctly. They should all be two TABs and a SPACE. Secondly, comments in the networking are to be formatted: /* Like * this. */ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists