[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130525.211116.1055819647914301942.davem@davemloft.net>
Date: Sat, 25 May 2013 21:11:16 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: lorenzo@...gle.com
Cc: netdev@...r.kernel.org, edumazet@...gle.com,
yoshfuji@...ux-ipv6.org, segoon@...nwall.com
Subject: Re: [PATCH] net: ipv6: Add IPv6 support to the ping socket.
From: Lorenzo Colitti <lorenzo@...gle.com>
Date: Thu, 23 May 2013 15:17:31 +0900
> This adds the ability to send ICMPv6 echo requests without a
> raw socket. The equivalent ability for ICMPv4 was added in
> 2011.
>
> Instead of having separate code paths for IPv4 and IPv6, make
> most of the code in net/ipv4/ping.c dual-stack and only add a
> few IPv6-specific bits (like the protocol definition) to a new
> net/ipv6/ping.c. Hopefully this will reduce divergence and/or
> duplication of bugs in the future.
>
> Caveats:
>
> - Setting options via ancillary data (e.g., using IPV6_PKTINFO
> to specify the outgoing interface) is not yet supported.
> - There are no separate security settings for IPv4 and IPv6;
> everything is controlled by /proc/net/ipv4/ping_group_range.
> - The proc interface does not yet display IPv6 ping sockets
> properly.
>
> Tested with a patched copy of ping6 and using raw socket calls.
> Compiles and works with all of CONFIG_IPV6={n,m,y}.
>
> Signed-off-by: Lorenzo Colitti <lorenzo@...gle.com>
Ok, looks pretty good, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists